fixed bug which prevented granule position to be set for longer audio files#33
Open
mozzbozz wants to merge 1 commit intoGagravarr:masterfrom
Open
fixed bug which prevented granule position to be set for longer audio files#33mozzbozz wants to merge 1 commit intoGagravarr:masterfrom
mozzbozz wants to merge 1 commit intoGagravarr:masterfrom
Conversation
… files; spelling mistake in comment; and editor stripped trailing spaces...
|
@mozzbozz Congratulation for this PR. I'm in wait for this PR to be merged. This issue is related to the bug fixed by this PR : https://gitlab.com/axet/android-audio-recorder/-/issues/208 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the bug was introduced in commit edc9273.
Basically, the contributor just forgot to reset the
doneFlush-flag tofalseagain after a flush was done. That resulted inpageSizebeing reset to0after every packet (after the first flush; which was at around 2 seconds for me). Therefore the granule position was only calculated correctly for the first page. After that it stayed fixed to one value and coursed audio players to freak out and display a wrong length for the file...Also I fixed a small spelling mistake in one of the source code comments. Additionally, my editor automatically stripped trailing spaces in some lines (of course I could've deactivated that feature but I think it makes sense).